On Mon, Jul 09, 2012 at 10:57:51AM +0100, Gordon Sim wrote: > You may be familiar[1] with the c++ test utilities qpid-send, > qpid-receive and the qpid-cpp-benchmark script that harnesses them > for simple performance testing. > > Pavel Moravec has been good enough to contribute a python port of > these utilities[2] and a modification (and rename) for > qpid-cpp-benchmark[3] to allow the script to drive either version of > the utilities (in any combination). (Thanks, Pavel!) > > There are a couple of questions I wanted to ask before getting these > contributions into the tree. > > (i) Where should the python utilities live? I was thinking about > creating a 'perf' directory under examples (alongside 'api) and > putting them in there. Though they aren't restricted to perf > testing, that would see to at least be obvious location).
If they're performance tests, why place them under examples? I would putting them under a sibling directory named util would be more logical, maybe util/perf. > > (ii) Is everyone ok with renaming qpid-cpp-benchmark? (Just taking > the 'cpp' out of it, since it can now run against either python or > c++ - the script itself is python). The script will otherwise be > entirely backward compatible, so for those who do rely on the > current name and can't change a symbolic link should be fine. +1 I don't think we should have any apps include an implementation detail like the language in the name. > (iii) Should we move the qpid-[cpp]-benchmark script out of the c++ > tree? This would be logically more consistent I think, e.g. it could > go under extras? (It could go under tools, but we may want to > distinguish between management tools and test utilities). +1 as well. We could collect all performance tests there rather than having them (potentially) peppered in different directories. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
pgpUoBfKcquZJ.pgp
Description: PGP signature
