On Mon, 2014-09-29 at 14:00 -0400, Ted Ross wrote: > > On 09/29/2014 12:01 PM, Andrew Stitcher wrote: > > On Sat, 2014-09-27 at 16:18 +0100, Fraser Adams wrote: > >> I just updated to r1627945 and when I do > >> cmake -DCMAKE_BUILD_TYPE=Debug .. > >> make > >> > >> I get: > >> > >> Linking C shared library libqpid-proton.so > >> CMakeFiles/qpid-proton.dir/src/codec/codec.c.o: In function > >> `pni_node_fields': > >> /home/fadams/qpid/qpid-trunk/proton/proton-c/src/codec/codec.c:99: > >> undefined reference to `pn_data_node' > > ... > > > > Without investigating fully, this looks like it is related to > > pn_data_node() being inline. I'd guess that in a debug build nothing is > > inlined, but because the function is marked inline no actual routine is > > generated for it. > > > > I think pn_data_node() was marked inline recently - perhaps it is not > > also marked 'static' which I think might give this error. > > I can confirm that marking pn_data_node static does fix the build in > Debug mode.
To clarify: When using C99 You must always make inline functions "static inline" anything else is a bug. If you compile your code using gcc or C++ then inline by itself will work (mostly). Andrew --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
