Giovanni, I was considering killing it as well. And I was going to look at how CentOS handled this in the 3.4.1 for their rpms.
-- Kevin A. McGrail Asst. Treasurer & VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171 On Fri, Apr 20, 2018 at 9:57 AM, Giovanni Bechis <giova...@paclan.it> wrote: > On 04/20/18 13:53, Kevin A. McGrail wrote: > > FYI, I'm well aware of the 3.4 test issue with rulesrc. I have it > symlinked to a checkout for my purposes. I'll document that more. > > > > I am using CentOS 7 as well for testing and not aware of these perl > dependency issues you are having. Please elaborate further. > > > I cannot find Devel::Size on Centos7 standard repositories. > As for RabinKarpAccel, the author says "Unfortunately, while it's great > for many parallel-match tasks, it's not so hot with SpamAssassin rules, > which is what I wrote it for" on his web page[¹] and I cannot find it on > cpan. > Is this plugin really useful ? From svn logs I can find that 12 years ago > jm@ wrote: > "reactivate RabinKarpBody plugin, which uses the Rabin-Karp algorithm to > perform fast body searches; not as fast as re2xs though". > > Giovanni > > [¹] http://taint.org/wk/JustinsSoftware > > > -- > > Kevin A. McGrail > > Asst. Treasurer & VP Fundraising, Apache Software Foundation > > Chair Emeritus Apache SpamAssassin Project > > https://www.linkedin.com/in/kmcgrail - 703.798.0171 > > > > On Fri, Apr 20, 2018 at 5:03 AM, Reio Remma <r...@mrstuudio.ee <mailto: > r...@mrstuudio.ee>> wrote: > > > > On 20.04.18 9:50, Giovanni Bechis wrote: > > > > On 04/19/18 09:24, Reio Remma wrote: > > [...] > > > > *Update:* none of the --option= switches work. > > > > handle_user (userdir) unable to find user: '' is caused > because I have the -username switch as --username=amavis instead of > --username amavis > > > > It worked in 3.4.1. > > > > Is it at all possible that I botched the RPM for 3.4.2? > > > > no, I botched it. > > Fixed in r1829628. > > Thanks > > Giovanni > > > > > > I can confirm that it works. > > > > Two things I wanted to point out that I noticed when building the > RPM for CentOS 7. There seem to be a few things in 3.4.2 branch that have > dependencies that don't exist in CentOS 7. > > > > --> Processing Dependency: perl(RabinKarpAccel) for package: > spamassassin-3.4.2-0.el7.centos.x86_64 > > --> Finished Dependency Resolution > > Error: Package: spamassassin-3.4.2-0.el7.centos.x86_64 > (/spamassassin-3.4.2-0.el7.centos.x86_64) > > Requires: perl(RabinKarpAccel) > > Error: Package: spamassassin-3.4.2-0.el7.centos.x86_64 > (/spamassassin-3.4.2-0.el7.centos.x86_64) > > Requires: perl(Devel::Size) > > > > To get around those I had to remove these (as I undersand they're > experimental anyway): > > > > Mail-SpamAssassin-3.4.2/lib/Mail/SpamAssassin/Plugin/NetCache.pm < > http://e.pm> > > Mail-SpamAssassin-3.4.2/lib/Mail/SpamAssassin/Util/MemoryDump.pm < > http://p.pm> > > Mail-SpamAssassin-3.4.2/lib/Mail/SpamAssassin/Plugin/ > RabinKarpBody.pm > > > > At first I tried removing all in MANIFEST.SKIP, but that seemed to > be too much for it. :) > > > > Also there are a couple of warnings when building: > > > > make -f spamc/Makefile spamc/spamc > > make[1]: Entering directory `/home/reio/rpmbuild/BUILD/ > Mail-SpamAssassin-3.4.2' > > make[1]: warning: jobserver unavailable: using -j1. Add `+' to > parent make rule. > > gcc -DSPAMC_SSL -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 > -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 > -grecord-gcc-switches -m64 -mtune=generic spamc/spamc.c spamc/getopt.c > spamc/libspamc.c spamc/utils.c \ > > -o spamc/spamc -lssl -lcrypto -ldl -lz > > spamc/libspamc.c: In function '_try_to_connect_tcp': > > spamc/libspamc.c:491:19: warning: variable 'family' set but not used > [-Wunused-but-set-variable] > > char *family = NULL; > > ^ > > spamc/libspamc.c: In function 'transport_setup': > > spamc/libspamc.c:1911:35: warning: unused variable 'addrp' > [-Wunused-variable] > > struct addrinfo hints, *res, *addrp; > > ^ > > spamc/libspamc.c: In function 'libspamc_log': > > spamc/libspamc.c:2239:9: warning: ignoring return value of 'write', > declared with attribute warn_unused_result [-Wunused-result] > > (void) write (2, buf, len); > > ^ > > make[1]: Leaving directory `/home/reio/rpmbuild/BUILD/ > Mail-SpamAssassin-3.4.2' > > > > > >
