On Wed, Dec 28, 2022 at 04:06:01PM +0200, Henrik K wrote:
> On Wed, Dec 28, 2022 at 01:58:55PM +0000, Riccardo Alfieri wrote:
> > On 28/12/22 14:44, Henrik K wrote:
> > 
> > > It is enabled by default for new installs in v342.pre (old users must 
> > > enable
> > > it manually).  But like with any other loadable plugin, one MUST check use
> > > "ifplugin" to check that it's loaded.
> > Ok, thanks for the clarification.
> > 
> > Would you then suggest to add also a:
> > 
> > ifplugin Mail::SpamAssassin::Plugin::URIDNSBL
> > 
> > to the .cf files where check_rbl , urirhssub etc are used?
> 
> It would be standard to use it yes.
> 
> Of course it's a bit of a double-edged sword, since with ifplugin the rules
> might silently be ignored.  Especially for Gentoo users.  ;-)

Maybe would be even good idea to use something like this:

ifplugin Mail::SpamAssassin::Plugin::HashBL
  ....
else
  error: Please activate HashBL plugin in v342.pre
endif

Which would result in:

$ spamassassin --lint
Dec 28 16:12:54.518 [764158] warn: config: failed to parse line in 
/var/foo/sh.cf (line 4): error: Please activate HashBL plugin in v342.pre
Dec 28 16:12:55.415 [764158] warn: lint: 1 issues detected, please rerun with 
debug enabled for more information

Of course this wouldn't be good for sa-updated rules.  Would need some way
to generate a warning without failing lint.

Reply via email to