On 7.4.2010 19:12, Mark Martinec wrote: > Jari, > >> Apr 7 10:07:41 lancaster check[1339]: Use of uninitialized value >> $origip in concatenation (.) or string at >> /usr/local/share/perl/5.10.0/Mail/SpamAssassin/AutoWhitelist.pm line 346. >> >> 3.3.1 in Debian Lenny, compiled via CPAN. >> >> I have not seen this message before, but now it came. I have no idea of >> the message which caused this. > > Probably as a result of a syntactically incorrect Received header field, > or incorrect parsing of it (see bug 6402). > > Here below is a patch to avoid warnings (which are innocent, but still...) > > Please open a bug report so that we can properly fold-in the patch.
I do not know how to open a bug report in SA ecosystem.
I reported it here, and I see that you have a possible patch already,
and you are a member of the developer community?
I hope you can open the bug report, as you now know as much as me, and
more, and you have an account in the bug reporting system?
Thanks.
>
>
> --- lib/Mail/SpamAssassin/AutoWhitelist.pm (revision 931157)
> +++ lib/Mail/SpamAssassin/AutoWhitelist.pm (working copy)
> @@ -324,7 +324,9 @@
> if (defined $result && length($result) > 39) { # just in case, keep under
> $result = substr($result,0,39); # the awl.ip field size
> }
> - dbg("auto-whitelist: IP masking %s -> %s", $origip,$result);
> + if (defined $result) {
> + dbg("auto-whitelist: IP masking %s -> %s", $origip,$result);
> + }
> return $result;
> }
>
> @@ -336,12 +338,13 @@
> $addr = lc $addr;
> $addr =~ s/[\000\;\'\"\!\|]/_/gs; # paranoia
>
> + if (defined $origip) {
> + $origip = $self->ip_to_awl_key($origip);
> + }
> if (!defined $origip) {
> # could not find an IP address to use, could be localhost mail
> # or from the user running "add-addr-to-*".
> $origip = 'none';
> - } else {
> - $origip = $self->ip_to_awl_key($origip);
> }
> return $addr . "|ip=" . $origip;
> }
>
>
>
> Mark
--
http://www.iki.fi/jarif/
I have never let my schooling interfere with my education.
-- Mark Twain
signature.asc
Description: OpenPGP digital signature
