On Sun, 2014-06-08 at 20:56 -0500, Chris wrote:
> In my etc/mail/spamassassin/local.cf I have the above line. I just

For completeness: That add_header option does work, although there are
actually exactly 3 arguments.

  add_header { spam | ham | all } header_name string

Just like stock configuration shows, the string argument should be
enclosed by double quotes.

  add_header all Date "of Scan _DATE_"

> upgraded to 3.4.0 today and I notice that the 'date of scan' is showing
> something like this:

Sic, it's the (X-Spam-) Date header, not "Date of Scan" header. ;)


> X-spam-date: of Scan Sat, 21 Feb 1976 13:57:28 -0500
> 
> Does this add header line not work anymore? Previous to the upgrade it
> was working correctly:
> 
> X-spam-date: of Scan Sun, 08 Jun 2014 12:35:11 -0500

Interesting. Unrelated to the number of arguments, though...

Found the culprit after some digging. Bug 6915 [1], revision 1453407. As
a band-aid, the following trivial one-line patch fixes it. Can easily be
applied manually.

Since it is kind of way past "getting late" here, and there may be other
Template Tags affected, I'll defer proper bug handling and committing
code changes for tomorrow.


--- lib/Mail/SpamAssassin/Util.pm       (revision 1601300)
+++ lib/Mail/SpamAssassin/Util.pm       (working copy)
@@ -582,6 +582,7 @@
 }
 
 sub time_to_rfc822_date {
+  my $pms = shift;
   my($time) = @_;
 
   my @days = qw/Sun Mon Tue Wed Thu Fri Sat/;


[1] https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6915

-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}

Reply via email to