On Mon, 1 Dec 2014, Burnie wrote:
On 11/30/2014 11:29 PM, John Hardin wrote:
> Would a corrected syntax version of this work?
>
> if version > 3.004001 && perl_version >= 5.010000
> body NON_588_COMPATIBLE_RE_SYNTAX /\w++/
> endif
Yes. That *does* work.
Thank you! I think you just solved it.
Define work...
-----------
if version > 3.004001 && perl_version >= 5.010000
body NON_588_COMPATIBLE_RE_SYNTAX /\w++/
endif
# spamassassin --lint
Dec 1 15:03:50.365 [28224] warn: Argument "perl_version" isn't numeric in
numeric ge (>=) at (eval 2520) line 2.
Dammit. I ran it (against trunk) here (with a different pseudo-var name,
and using version > 9) and did *not* get a type warning!
if version > 1 && fnord_should_be_skipped >= 5.010000
body NON_588_COMPATIBLE_RE_SYNTAX /\w++/
endif
gives:
Dec 1 09:08:36.622 [22970] warn: Argument "fnord_should_be_skipped" isn't
numeric in numeric ge (>=) at (eval 2555) line 1.
Dec 1 09:08:37.481 [22970] dbg: message: main message type: text/plain
if version > 4 && fnord_should_be_skipped >= 5.010000
body NON_588_COMPATIBLE_RE_SYNTAX /\w++/
endif
gives:
Dec 1 09:09:49.486 [22988] dbg: message: main message type: text/plain
But I was thinking another solution to the problem;
Since there already are quite a few changes to 3.4(+) (quite a few
checking for version >= 3.004000 in the rulesets)
How difficult would it be to split 3.4.1(+) rulesets from pre-3.4.1
rulesets? Older SA/sa-update would then fetch rulesets without the
new checks, and new sa-update would benefit from the new checks...
That may need to be what happens.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhar...@impsec.org FALaholic #11174 pgpk -a jhar...@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
There is no better measure of the unthinking contempt of the
environmentalist movement for civilization than their call to
turn off the lights and sit in the dark. -- Sultan Knish
-----------------------------------------------------------------------
14 days until Bill of Rights day
