Stefan Sperling <s...@elego.de> writes: > On Tue, Nov 01, 2011 at 11:31:35AM -0600, michael_rytt...@agilent.com wrote: > Note that I am not going to commit this as is. > It just tests whether the overhead of sorting paths in sqlite matters > much on NFS. > > Index: subversion/libsvn_wc/wc-queries.sql > =================================================================== > --- subversion/libsvn_wc/wc-queries.sql (revision 1196149) > +++ subversion/libsvn_wc/wc-queries.sql (working copy) > @@ -1208,7 +1208,6 @@ WHERE wc_id = ?1 > > -- STMT_SELECT_DELETE_LIST > SELECT local_relpath FROM delete_list > -ORDER BY local_relpath > > -- STMT_FINALIZE_DELETE > DROP TABLE IF EXISTS delete_list
I put in the ORDER BY to preserve the parents before children notification used by 1.6. I wonder if that notification order is important? A patch that we could commit without affecting the order is: Index: subversion/libsvn_wc/wc-queries.sql =================================================================== --- subversion/libsvn_wc/wc-queries.sql (revision 1196106) +++ subversion/libsvn_wc/wc-queries.sql (working copy) @@ -1193,7 +1193,7 @@ CREATE TEMPORARY TABLE delete_list ( /* ### we should put the wc_id in here in case a delete spans multiple ### working copies. queries, etc will need to be adjusted. */ - local_relpath TEXT PRIMARY KEY NOT NULL + local_relpath TEXT PRIMARY KEY NOT NULL UNIQUE ) /* This matches the selection in STMT_INSERT_DELETE_FROM_NODE_RECURSIVE */ -- Philip