I'm trying to build up a subversion-1.8.0 SRPM toolkit, and have
noticed a little "svnucc" deployment bug.

Specifically, the Makefile winds up saying this:

# Compatibility symlink.
# This runs after the target of the same name in build-outputs.mk.
INSTALL_EXTRA_TOOLS=\
  $(MKDIR) $(DESTDIR)$(bindir); \
  test -n "$$SVN_SVNMUCC_IS_SVNSYITF" && \
  ln -sf svnmucc$(EXEEXT) $(DESTDIR)$(bindir)/svnsyitf$(EXEEXT); \
  if test "$(DESTDIR)$(bindir)" != "$(DESTDIR)$(toolsdir)"; then \
    ln -sf $(DESTDIR)$(bindir)/svnmucc$(EXEEXT)
$(DESTDIR)$(toolsdir)/svnmucc$(EXEEXT); \
  fi


Unfortunately, when building RPM's "DESTDIR" is the location of the
RPM "BUILDROOT" location, not the atual deployment location. So it
needs to be:

    ln -sf $(bindir)/svnmucc$(EXEEXT) $(DESTDIR)$(toolsdir)/svnmucc$(EXEEXT); \

So can I safely assume that I just need to patch that for RPM building?

Reply via email to