On Fri, Jun 21, 2013 at 4:45 AM, Philip Martin
<philip.mar...@wandisco.com> wrote:
> Nico Kadel-Garcia <nka...@gmail.com> writes:
>
>> # Compatibility symlink.
>> # This runs after the target of the same name in build-outputs.mk.
>> INSTALL_EXTRA_TOOLS=\
>>   $(MKDIR) $(DESTDIR)$(bindir); \
>>   test -n "$$SVN_SVNMUCC_IS_SVNSYITF" && \
>>   ln -sf svnmucc$(EXEEXT) $(DESTDIR)$(bindir)/svnsyitf$(EXEEXT); \
>>   if test "$(DESTDIR)$(bindir)" != "$(DESTDIR)$(toolsdir)"; then \
>>     ln -sf $(DESTDIR)$(bindir)/svnmucc$(EXEEXT)
>> $(DESTDIR)$(toolsdir)/svnmucc$(EXEEXT); \
>>   fi
>>
>>
>> Unfortunately, when building RPM's "DESTDIR" is the location of the
>> RPM "BUILDROOT" location, not the atual deployment location. So it
>> needs to be:
>>
>>     ln -sf $(bindir)/svnmucc$(EXEEXT) 
>> $(DESTDIR)$(toolsdir)/svnmucc$(EXEEXT); \
>>
>> So can I safely assume that I just need to patch that for RPM building?
>
> That should work.  I fixed Makefile.in in r1495329.
>
> Does your binary package include /usr/bin/svn-tools?

Yes, it does. Thanks. The original but of shell scripting is a classic
attempt to have a Makefile outsimart a standard build procedure, and
it's not surprising when these break down in actual package building
environments. In fact, I'm not sure that it *should* be altered for
normal, non-RPM building deployment.

Reply via email to