i wouldn't worry about that js performance and i do believe that the
current is the
correct default behavior but i do understand that this change breaks
existing running apps.
I see three options:
- bring the ids back (framework change)
- implement some kind of postprocessor that adds an id to all labels
(application change,
but the code could eventually live in the framework)
- modify application js
On Fri, Dec 17, 2010 at 19:12, Robert Zeigler <robe...@scazdl.org> wrote:
> That's all true, and well. Except. We have apps out "in the wild" that rely
> on the id being generated.
>
> As for - to _ in identifiers, I don't remember the exact issue, but there's a
> jira for it and it has to do with invalid identifiers, or the - in names
> causing problems in some circumstances (the details escape me at the moment,
> sorry).
>
> Robert
>
> On Dec 17, 2010, at 12/1710:51 AM , Andreas Andreou wrote:
>
>> It makes sense to me to not output redundant html....
>> And if you know the id of the control you can get to its label by
>> $$('label[for=' + id + ']')
>>
>> On Fri, Dec 17, 2010 at 18:35, Blower, Andy <andy.blo...@proquest.co.uk>
>> wrote:
>>> The change was made in July and doesn't appear to be associated with a JIRA:
>>>
>>> r931361 | hlship | 2010-04-07 00:01:00 BST
>>>
>>> Do not render an id attribute for Label components, as they can be
>>> identified via their for attribute
>>>
>>>
>>> Yes they can, but it's pretty standard to find tags in the dom via id's,
>>> especially when using prototype.
>>>
>>> Howard, can you explain why this change was necessary, and the thinking
>>> behind it.
>>>
>>> Unfortunately this change has broken our client side validation error
>>> messages. We only noticed yesterday. The change immediately before it
>>> changed the - to a _ before the 'label' suffix. I'd like to know why this
>>> was done before I raise a JIRA.
>>>
>>> Thanks,
>>>
>>> Andy.
>>>
>>
>>
>>
>> --
>> Andreas Andreou - andy...@apache.org - http://blog.andyhot.gr
>> Tapestry PMC / Tacos developer
>> Open Source / JEE Consulting
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
>> For additional commands, e-mail: users-h...@tapestry.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
> For additional commands, e-mail: users-h...@tapestry.apache.org
>
>
--
Andreas Andreou - andy...@apache.org - http://blog.andyhot.gr
Tapestry PMC / Tacos developer
Open Source / JEE Consulting
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
For additional commands, e-mail: users-h...@tapestry.apache.org
