Am 2013-05-08 14:08, schrieb Nick Williams:
On May 8, 2013, at 6:54 AM, Christopher Schultz wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Michael,
On 5/8/13 3:01 AM, Michael-O wrote:
I recently have started using the SlowQueryReport to tackle
performance issues. The log message, unfortunately, does not
contain the parameters passed to the prepared statements. Though
AbstractQueryReport receives this information in
protected String report*Query(String query, Object[] args, final
String name, long start, long delta)
but ignores this information. The report would highly benefit
from. E.g., Commons DBUtils prints out the query and the
parameters in the case of an exception. The sole query isn't
really helpful.
Can we add this?
Sure.
Should I file a ticket?
Yes. A BZ issue with a patch is likely to get done a whole lot
faster than one without a patch (plus you get credit for your
contribution).
- -chris
There needs to be an option to disable logging query parameters
somehow. Query parameters are sometimes sensitive, and in some
environments (medical, legal, etc.) logging them might even be in
violation of the law.
Agreed, but this won't work if someone failed to use prepared statements
and uses StringBuilder to create the entire string.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org
