Ok, I fixed the styling and the documentation. If anything else must be changed, don't hesitate.
Thanks, Xavier. ---------------------------------------- > Date: Thu, 12 Sep 2013 12:01:26 +0100 > From: ma...@apache.org > To: users@tomcat.apache.org > Subject: Re: Using EL expressions in an ObjectFactory > > On 12/09/2013 11:49, Xavier Dury wrote: >> Hi, >> >> I implemented a simple ExpressionFactory @ >> https://github.com/kalgon/expression-factory. >> >> I would love to see this ExpressionFactory next to >> org.apache.naming.factory.BeanFactory in tomcat. > > No objections in principle. > > Haven't looked at the new code in detail. A few initial observations: > - I'm assuming this is a contribution as per section 5 of the Apache > License, version 2.0 > - There is no documentation > - Tomcat code standards use 4 spaces for indents, not tabs > - Some @Override markers look to be missing > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
