Thanks Mark,

I will try that out and let you know if it sorts our issue.

Much appreciated

On 26 May 2017 at 12:59, Mark Thomas <ma...@apache.org> wrote:

> On 26/05/17 10:15, David Kavanagh wrote:
> > Hey guys,
> >
> > Thanks for getting back to me. I didn't realise that the attachments
> would
> > be stripped.>
> > Here are the two files in full.
>
> That isn't enough for us to reproduce it. Those files refer to a handful
> of other tag files and classes we don't have.
>
> However, I have been able to derive a simple test case from it:
>
> =====start======
> <p class="${'foo'} ${'bar'}">This is a test</p>
> ======end=======
>
> The output with trimSpaces enabled is:
>
> =====start======
> <p class="foobar">This is a test</p>
> ======end=======
>
> trimSpaces is behaving exactly as designed. It removes any blocks of
> template text that consist solely of white space.
>
> What you have is:
> TemplateText [<p class="]
> Expression   [${'foo'}]
> TemplateText [ ]
> Expression   [${'bar'}]
> TemplateText [">This is a test</p>]
>
> Because the second template text is empty, it gets removed.
>
> The fix is:
>
> =====start======
> <p class="${'foo'}${' '}${'bar'}">This is a test</p>
> ======end=======
>
> This is a potential use case for a recently closed (as WONTFIX)
> enhancement request:
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=45931
>
> Whether this use case is sufficient to justify re-opening that
> enhancement request, reviewing the patch and updating it for 9.0.x is
> TBD. How realistic is it for you to apply the fix (using ${' '})
> described above?
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
>

Reply via email to