I wasn't gonna say anything about that, but I did consult my "operator precedence" reference while looking at it... :-) +1 on parens!
Dan On Tue, May 24, 2011 at 5:21 PM, Christopher Schultz <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Dan, > > On 5/24/2011 5:09 PM, Dan Checkoway wrote: >> - } else if (CookieSupport.isHttpToken(value) && >> - !CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0 || >> - CookieSupport.isV0Token(value) && >> - CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0) { >> + } else if (!CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0 && >> + CookieSupport.isHttpToken(value) || >> + CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0 && >> + CookieSupport.isV0Token(value)) { > > Ooh... looks like that expression could use some parentheses, too. > > - -chris > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.10 (MingW32) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAk3cIV8ACgkQ9CaO5/Lv0PCnLgCeMu4DbPnKULW5m5Hvm1b63c6i > XSwAn0IDD6jd5xmTKg+WhSuC4qPWULay > =tHC+ > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
