-1 for this. I'm very much against the current "static util" pattern that the HeaderContributor object is headed. I would much rather have this behavior moved into the appropriate class (ex: JavascriptResource.headerContribution()) instead of bloating HeaderContributor. this is how i designed the wicket FeedResource. http://www.jroller.com/wireframe/entry/wicket_feedresource
On Nov 29, 2007 8:00 AM, Alex Objelean <[EMAIL PROTECTED]> wrote: > > Also this can be done extending PackagedResourceReference, but this is not > the point. > I found myself copying the same code from one project to another, just > because wicket core does not provide a common way to add favicons. I think, > that since HeaderContributor has already: forCss & forJavaScript, it would > not be a big deal to add also forFavicon method. > > Regards, > Alex. > > > > Matej Knopp-2 wrote: > > > > You can do this by directly using IHeaderResponse.renderString(). > > e.g. make a custom behavior that implements IHeaderContributor and > > call this from it's renderHead. > > I don't think we need this in HeaderContributor itself. But others > > might have different opinion. > > > > -Matej > > > > On Nov 29, 2007 11:08 AM, Alex Objelean <[EMAIL PROTECTED]> > > wrote: > >> > >> I find it very useful to be able to add a favicon reference easily, using > >> HeaderContributor. What do you think? > >> > >> > >> Note: > >> Favicon is a link with the following attributes: rel: "shortcut icon" & > >> type: "image/x-icon". > >> For example: <link rel="shortcut icon" type="image/x-icon" > >> href="/resources/....favicon.ico"></link> > >> > >> Alex. > >> -- > >> View this message in context: > >> http://www.nabble.com/-RFE--HeaderContributor.forFavicon%28Reference%29-tf4896178.html#a14022731 > >> Sent from the Wicket - User mailing list archive at Nabble.com. > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > -- > View this message in context: > http://www.nabble.com/-RFE--HeaderContributor.forFavicon%28Reference%29-tf4896178.html#a14025400 > > Sent from the Wicket - User mailing list archive at Nabble.com. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
