Hi,
Found some minor problems in latest utrace patch.
1. ******
arch/ia64/ia32/sys_ia32.c
do_fpregs_set(struct unw_frame_info *info, void *arg)
+ for (; start < end; start++)
+ access_fpreg_ia32(start, (struct _fpreg_ia32
*)buf + start,
+ pt, info->sw, tos, 0);
I guess it maybe
+ for (; start < end; start++)
+ access_fpreg_ia32(start, (struct _fpreg_ia32
*)buf + start,
+ pt, info->sw, tos, 1);
2. *******
tracehook_inhibit_wait_stopped, tracehook_inhibit_wait_zombie,
tracehook_inhibit_wait_continued have same
parameter and function body. How about to merge them into one?
3. *******
There are some unused parameters in tracehook_report_clone_complete,
tracehook_report_vfork_done, tracehook_report_handle_signal.
To keep good interface ?
4. *******
linux-2.6/include/linux/ptrace.h
+/* Convenience wrapper for the common PTRACE_PEEKUSR implementation.
*/
+static inline int ptrace_pokeusr(struct task_struct *child,
And
+/* Convenience wrapper for the common PTRACE_PEEKUSR implementation.
*/
+static inline int ptrace_compat_pokeusr(
Should be:
+/* Convenience wrapper for the common PTRACE_POKEUSR implementation.
*/
5. *******
linux-2.6/include/asm-x86/ptrace-abi.h
@@ -78,4 +78,7 @@
# define PTRACE_SYSEMU_SINGLESTEP 32
#endif
+#define PTRACE_SYSEMU 31
+#define PTRACE_SYSEMU_SINGLESTEP 32
+
For i386, PTRACE_SYSEMU and PTRACE_SYSEMU_SINGLESTEP are defined two times.
6. *******
linux-2.6/include/asm-avr32/tracehook.h
+#define ARCH_HAS_SINGLE_STEP 1
Maybe like others:
+#define ARCH_HAS_SINGLE_STEP (1)
Happy New Year!
Regards,
Wenji
