LGTM, except spliting should be splitting. Maybe we should mention issue numbers in the ChangeLog where appropriate? Especially for important bug fixes.
On Thu, Sep 11, 2008 at 10:19 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Update version string and ChangeLog, we are now working on version > 0.3.2. > > Please review this at http://codereview.chromium.org/2417 > > Affected files: > M ChangeLog > M src/api.cc > > > Index: src/api.cc > =================================================================== > --- src/api.cc (revision 263) > +++ src/api.cc (working copy) > @@ -2216,7 +2216,7 @@ > > > const char* v8::V8::GetVersion() { > - return "0.3.1 (internal)"; > + return "0.3.2 (internal)"; > } > > > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 263) > +++ ChangeLog (working copy) > @@ -1,3 +1,48 @@ > +2008-09-11: Version 0.3.1 > + > + Fixed a number of build issues. > + > + Fixed problem with missing I-cache flusing on ARM. > + > + Changed space layout in memory management by spliting up > + code space into old data space and code space. > + > + Added utf-8 conversion support to the API. > + > + Optimized repeated calls to eval with the same strings. These > + repeated calls are common in web applications. > + > + Added Xcode project file. > + > + Optimized a couple of Array operation. > + > + Fixed parser bug by checking for end-of-string when parsing break > + and continue. > + > + Fixed problem where asian characters were not categorized as > + letters. > + > + Fixed bug that disallowed calling functions fetched from an array > + using a string as an array index. > + > + Fixed bug where the internal field count on object templates were > + sometimes ignored. > + > + Added -f option to the shell sample for compatibility with other > + engines. > + > + Added source info to TryCatches in the API. > + > + Fixed problem where the seed for the random number generator was > + clipped in a double to unsigned int conversion. > + > + Fixed bug where cons string symbols were sometimes converted to > + non-symbol flat strings during GC. > + > + Fixed bug in error reporting when attempting to convert null to an > + object. > + > + > 2008-09-04: Version 0.3.0 > > Added support for running tests on the ARM simulator. > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
