LGTM Thanks for also cleaning up the comments.
-Ivan http://codereview.chromium.org/9182/diff/201/202 File src/codegen-arm.cc (right): http://codereview.chromium.org/9182/diff/201/202#newcode104 Line 104: __ add(sp, sp, Operand(kPointerSize)); Shouldn't this just call Drop(1)? http://codereview.chromium.org/9182/diff/201/202#newcode172 Line 172: // cp: callee's context Drive by comment not related to this change: This is redundant to the "calling convention" comment below and I do believe that both are wrong now that the calling convention changed! Filed issue 141: http://code.google.com/p/v8/issues/detail?id=141 http://codereview.chromium.org/9182/diff/201/202#newcode193 Line 193: // cp: callee's context ditto http://codereview.chromium.org/9182/diff/201/202#newcode574 Line 574: if (size <= 0) { Can a reference size ever be negative? If not, then we should ASSERT that instead. Would make the code slightly more readable. http://codereview.chromium.org/9182 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
