http://codereview.chromium.org/9182/diff/201/202 File src/codegen-arm.cc (right):
http://codereview.chromium.org/9182/diff/201/202#newcode104 Line 104: __ add(sp, sp, Operand(kPointerSize)); On 2008/11/06 18:18:34, iposva wrote: > Shouldn't this just call Drop(1)? Fixed. http://codereview.chromium.org/9182/diff/201/202#newcode574 Line 574: if (size <= 0) { On 2008/11/06 18:18:34, iposva wrote: > Can a reference size ever be negative? If not, then we should ASSERT that > instead. Would make the code slightly more readable. Yes it can be negative, but we should probably change that. The size is just the (integer) value of the type enum, and ILLEGAL has value -1. I will investigate and clean up as a separate change. http://codereview.chromium.org/9182 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
