It complains because it's actually a bug (order of precedence). LGTM.
On Tue, Nov 11, 2008 at 10:37 AM, <[EMAIL PROTECTED]> wrote: > > Reviewers: iposva, > > Message: > a small fix > > Description: > cl.exe complains about missing parens around the boolean expression. > > > Please review this at http://codereview.chromium.org/10298 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/objects.cc > > > Index: src/objects.cc > =================================================================== > --- src/objects.cc (revision 735) > +++ src/objects.cc (working copy) > @@ -3848,7 +3848,7 @@ > const int kAlignmentMask = sizeof(uint32_t) - 1; // NOLINT > uint32_t pa_addr = reinterpret_cast<uint32_t>(pa); > uint32_t pb_addr = reinterpret_cast<uint32_t>(pb); > - if ((pa_addr & kAlignmentMask) | (pb_addr & kAlignmentMask) == 0) { > + if (((pa_addr & kAlignmentMask) | (pb_addr & kAlignmentMask)) == 0) { > #endif > const int kStepSize = sizeof(int) / sizeof(Char); // NOLINT > int endpoint = length - kStepSize; > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
