On Tue, Nov 11, 2008 at 8:13 PM, Erik Corry <[EMAIL PROTECTED]> wrote:
> > There's another bug here because Intel CPUs are quite capable of reading > unaligned data and so we shouldn't even get into this code on Windows. Or perhaps you were compiling for the ARM simulator on Windows. In which case perhaps this fixes http://code.google.com/p/v8/issues/detail?id=130 > > > On Tue, Nov 11, 2008 at 7:38 PM, Dean McNamee <[EMAIL PROTECTED]> wrote: > >> >> It complains because it's actually a bug (order of precedence). >> >> LGTM. >> >> On Tue, Nov 11, 2008 at 10:37 AM, <[EMAIL PROTECTED]> wrote: >> > >> > Reviewers: iposva, >> > >> > Message: >> > a small fix >> > >> > Description: >> > cl.exe complains about missing parens around the boolean expression. >> > >> > >> > Please review this at http://codereview.chromium.org/10298 >> > >> > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> > >> > Affected files: >> > M src/objects.cc >> > >> > >> > Index: src/objects.cc >> > =================================================================== >> > --- src/objects.cc (revision 735) >> > +++ src/objects.cc (working copy) >> > @@ -3848,7 +3848,7 @@ >> > const int kAlignmentMask = sizeof(uint32_t) - 1; // NOLINT >> > uint32_t pa_addr = reinterpret_cast<uint32_t>(pa); >> > uint32_t pb_addr = reinterpret_cast<uint32_t>(pb); >> > - if ((pa_addr & kAlignmentMask) | (pb_addr & kAlignmentMask) == 0) { >> > + if (((pa_addr & kAlignmentMask) | (pb_addr & kAlignmentMask)) == 0) { >> > #endif >> > const int kStepSize = sizeof(int) / sizeof(Char); // NOLINT >> > int endpoint = length - kStepSize; >> > >> > >> > >> > > >> > >> >> >> >> > > > -- > Erik Corry, Software Engineer > Google Denmark ApS. CVR nr. 28 86 69 84 > c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen > K, Denmark. > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
