Author: whessev8
Date: Wed Dec 17 06:35:41 2008
New Revision: 992
Modified:
branches/experimental/toiger/src/codegen-ia32.cc
branches/experimental/toiger/src/codegen-ia32.h
branches/experimental/toiger/src/jump-target-arm.cc
branches/experimental/toiger/src/register-allocator-ia32.h
branches/experimental/toiger/src/virtual-frame-arm.h
Log:
Fix lint errors - spacing and formatting.
Review URL: http://codereview.chromium.org/14193
Modified: branches/experimental/toiger/src/codegen-ia32.cc
==============================================================================
--- branches/experimental/toiger/src/codegen-ia32.cc (original)
+++ branches/experimental/toiger/src/codegen-ia32.cc Wed Dec 17 06:35:41
2008
@@ -571,7 +571,8 @@
// ECMA-262, section 9.2, page 30: ToBoolean(). Pop the top of stack and
// convert it to a boolean in the condition code register or jump to
// 'false_target'/'true_target' as appropriate.
-void CodeGenerator::ToBoolean(JumpTarget* true_target, JumpTarget*
false_target) {
+void CodeGenerator::ToBoolean(JumpTarget* true_target,
+ JumpTarget* false_target) {
Comment cmnt(masm_, "[ ToBoolean");
// The value to convert should be popped from the stack.
@@ -4067,8 +4068,8 @@
// Uncommon case: typeof testing against a string literal that is
// never returned from the typeof operator.
false_target()->Jump();
- // TODO(): Can this cause a problem because it is an expression that
- // exits without a virtual frame in place?
+ // TODO(kmilliken) : Can this cause a problem because it is an
expression
+ // that exits without a virtual frame in place?
}
return;
}
Modified: branches/experimental/toiger/src/codegen-ia32.h
==============================================================================
--- branches/experimental/toiger/src/codegen-ia32.h (original)
+++ branches/experimental/toiger/src/codegen-ia32.h Wed Dec 17 06:35:41 2008
@@ -83,8 +83,8 @@
void GetValue(TypeofState typeof_state);
// Generate code to push the value of a reference on top of the
expression
- // stack and then spill the stack frame. This function is used
temporarily while
- // the code generator is being transformed.
+ // stack and then spill the stack frame. This function is used
temporarily
+ // while the code generator is being transformed.
inline void GetValueAndSpill(TypeofState typeof_state);
// Generate code to store the value on top of the expression stack in the
Modified: branches/experimental/toiger/src/jump-target-arm.cc
==============================================================================
--- branches/experimental/toiger/src/jump-target-arm.cc (original)
+++ branches/experimental/toiger/src/jump-target-arm.cc Wed Dec 17 06:35:41
2008
@@ -130,7 +130,7 @@
ASSERT(expected_frame_ == NULL);
expected_frame_ = new VirtualFrame(current_frame);
- // Adjust the expected frame's height to account for the return address
+ // Adjust the expected frame's height to account for the return address
// pushed by the call instruction.
expected_frame_->Adjust(1);
Modified: branches/experimental/toiger/src/register-allocator-ia32.h
==============================================================================
--- branches/experimental/toiger/src/register-allocator-ia32.h (original)
+++ branches/experimental/toiger/src/register-allocator-ia32.h Wed Dec 17
06:35:41 2008
@@ -81,7 +81,7 @@
class RegisterAllocator BASE_EMBEDDED {
public:
- RegisterAllocator(CodeGenerator* cgen) : code_generator_(cgen) {}
+ explicit RegisterAllocator(CodeGenerator* cgen) : code_generator_(cgen)
{}
int num_registers() const { return RegisterFile::kNumRegisters; }
Modified: branches/experimental/toiger/src/virtual-frame-arm.h
==============================================================================
--- branches/experimental/toiger/src/virtual-frame-arm.h (original)
+++ branches/experimental/toiger/src/virtual-frame-arm.h Wed Dec 17
06:35:41 2008
@@ -56,7 +56,7 @@
// as random access to the expression stack elements, locals, and
// parameters.
-class VirtualFrame : public Malloced{
+class VirtualFrame : public Malloced {
public:
// Construct a virtual frame with the given code generator used to
// generate code.
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
