LGTM. We still need some better tests.
http://codereview.chromium.org/14483/diff/12/15 File src/v8threads.cc (right): http://codereview.chromium.org/14483/diff/12/15#newcode310 Line 310: singleton_ = NULL; Perhaps here we should clear a pending preemption. It might be confusing to have it discovered after this point? http://codereview.chromium.org/14483/diff/12/16 File src/v8threads.h (right): http://codereview.chromium.org/14483/diff/12/16#newcode91 Line 91: // multiple running V8 threads. Generally it is needed to call StartPreemption "it is necessary" http://codereview.chromium.org/14483/diff/12/16#newcode92 Line 92: // if there is more than one thread running. If not a single JavaScript can "If not, a single JavaScript thread can" http://codereview.chromium.org/14483/diff/12/16#newcode102 Line 102: // Preempted thread needs to calls back to the ContextSwitcher to acknowlege "to call back" http://codereview.chromium.org/14483/diff/12/13 File test/cctest/test-threads.cc (right): http://codereview.chromium.org/14483/diff/12/13#newcode3 Line 3: // Check that we can traverse very deep stacks of ConsStrings using Stale comment (should be replaced with copyright boilerplate) http://codereview.chromium.org/14483 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
