I agree that we need more tests. By adding this new cctest file we now have a place where they can go.
-Ivan http://codereview.chromium.org/14483/diff/12/15 File src/v8threads.cc (right): http://codereview.chromium.org/14483/diff/12/15#newcode310 Line 310: singleton_ = NULL; On 2008/12/17 14:30:07, Erik Corry wrote: > Perhaps here we should clear a pending preemption. It might be confusing to > have it discovered after this point? I disagree. To the running thread a pending preemption will appear like a spurious interrupt, the thread has to be able to handle that anyway. Also you would need to iterate through all the threads clearing all pending interrupts. http://codereview.chromium.org/14483/diff/12/16 File src/v8threads.h (right): http://codereview.chromium.org/14483/diff/12/16#newcode91 Line 91: // multiple running V8 threads. Generally it is needed to call StartPreemption On 2008/12/17 14:30:07, Erik Corry wrote: > "it is necessary" Done. http://codereview.chromium.org/14483/diff/12/16#newcode92 Line 92: // if there is more than one thread running. If not a single JavaScript can On 2008/12/17 14:30:07, Erik Corry wrote: > "If not, a single JavaScript thread can" Done. http://codereview.chromium.org/14483/diff/12/16#newcode102 Line 102: // Preempted thread needs to calls back to the ContextSwitcher to acknowlege On 2008/12/17 14:30:07, Erik Corry wrote: > "to call back" Done. http://codereview.chromium.org/14483/diff/12/13 File test/cctest/test-threads.cc (right): http://codereview.chromium.org/14483/diff/12/13#newcode3 Line 3: // Check that we can traverse very deep stacks of ConsStrings using On 2008/12/17 14:30:07, Erik Corry wrote: > Stale comment (should be replaced with copyright boilerplate) Done. http://codereview.chromium.org/14483 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
