http://codereview.chromium.org/113199/diff/1/2 File src/disassembler.cc (right):
http://codereview.chromium.org/113199/diff/1/2#newcode46 Line 46: PrintF("%"V8PRIp" %4"V8PRId" %02x\n", pc, pc - begin, *pc); should we put space around these? It looks weird, but I guess it will look weird no matter what. http://codereview.chromium.org/113199/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/113199/diff/1/4#newcode6729 Line 6729: static_cast<uint32_t>(reinterpret_cast<uintptr_t>(map)); comment about truncation? http://codereview.chromium.org/113199/diff/1/5 File src/runtime.cc (right): http://codereview.chromium.org/113199/diff/1/5#newcode4448 Line 4448: #ifdef V8_HOST_ARCH_64_BIT I have just been doing #if, we should be consistent and go with one. I thin #if is easier. http://codereview.chromium.org/113199/diff/1/5#newcode6040 Line 6040: #ifdef V8_HOST_ARCH_64_BIT #if http://codereview.chromium.org/113199 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
