LGTM
http://codereview.chromium.org/113199/diff/1/2 File src/disassembler.cc (right): http://codereview.chromium.org/113199/diff/1/2#newcode46 Line 46: PrintF("%"V8PRIp" %4"V8PRId" %02x\n", pc, pc - begin, *pc); On 2009/05/12 08:22:40, Dean McNamee wrote: > should we put space around these? It looks weird, but I guess it will look > weird no matter what. I think the names are way too cryptic considering they are not used all that many places. The name V8PRId does not say "use this where you want to print a ptrdiff_t" to me. I would suggest something like POINTER_PRINT and PTRDIFF_PRINT and as Dean says, normal spacing. http://codereview.chromium.org/113199/diff/1/5 File src/runtime.cc (right): http://codereview.chromium.org/113199/diff/1/5#newcode4445 Line 4445: // TODO(x64): Definitly! spolling! http://codereview.chromium.org/113199/diff/1/7 File src/x64/cpu-x64.cc (right): http://codereview.chromium.org/113199/diff/1/7#newcode49 Line 49: // If flushing of the instruction cache becomes necessary Windows have the have->has http://codereview.chromium.org/113199 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
