LGTM, Lars
http://codereview.chromium.org/115086/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/115086/diff/1/2#newcode629 Line 629: promoted_rear = reinterpret_cast<HeapObject**>(new_space_.ToSpaceHigh()); How about: promoted_rear = promoted_front; http://codereview.chromium.org/115086/diff/1/2#newcode659 Line 659: // to-be-promoted objects. Process them until the queue is empty. It would be much easier to read if you used an abstraction for the queue. This also reduces the complexity of this function. http://codereview.chromium.org/115086/diff/1/2#newcode662 Line 662: Map* map = Map::cast(*(--promoted_front)); while (!queue.is_empty()) { HeapObject* source; Map* map; queue.remove(&source, &map); ... } http://codereview.chromium.org/115086/diff/1/2#newcode893 Line 893: *(--promoted_rear) = first_word.ToMap(); queue.insert(object, first_word.ToMap()); http://codereview.chromium.org/115086/diff/1/2#newcode902 Line 902: // Update *p. This comment does not add anything. http://codereview.chromium.org/115086/diff/1/2#newcode905 Line 905: // Objects promoted to the data space can be copied immediately NOTE: this is only an optimization. http://codereview.chromium.org/115086 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
