I've updated this changelist with the simple queue implementation. You might want to have a quick look again.
On Wed, May 13, 2009 at 10:17 AM, <[email protected]> wrote: > > http://codereview.chromium.org/115086/diff/1/2 > File src/heap.cc (right): > > http://codereview.chromium.org/115086/diff/1/2#newcode659 > Line 659: // to-be-promoted objects. Process them until the queue is > empty. > On 2009/05/12 12:17:51, bak wrote: > >> It would be much easier to read if you used an abstraction for the >> > queue. This > >> also reduces the complexity of this function. >> > > I thought about that. I got hung up on trying to come up with something > simple that worked for both the promoted pointers and non-promoted > objects. > > I'll adopt your suggestion of just doing it for the promoted ones, which > is the messy part anyway. > > > http://codereview.chromium.org/115086 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
