LGTM if you revert more unrelated changes
https://codereview.chromium.org/356213003/diff/40001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/356213003/diff/40001/src/hydrogen.cc#newcode1517
src/hydrogen.cc:1517: IfBuilder internalized(this);
nit: I think "not_internalized" would more accurately convey what it
checks
https://codereview.chromium.org/356213003/diff/40001/src/hydrogen.cc#newcode1532
src/hydrogen.cc:1532: // Key guaranteed to be a unqiue string
nit: while you're here, "unique"
https://codereview.chromium.org/356213003/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/356213003/diff/40001/src/runtime.cc#newcode1607
src/runtime.cc:1607: SealHandleScope shs(isolate);
no
https://codereview.chromium.org/356213003/diff/40001/src/runtime.h
File src/runtime.h (right):
https://codereview.chromium.org/356213003/diff/40001/src/runtime.h#newcode277
src/runtime.h:277: F(SetIteratorNext, 2, 1) \
no
https://codereview.chromium.org/356213003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
