https://codereview.chromium.org/356213003/diff/60001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/356213003/diff/60001/src/hydrogen.cc#newcode1521
src/hydrogen.cc:1521: not_internalized.Then();
Now you've changed both the name and the meaning. (Or am I confused?)
Either the IfBuilder should be called "internalized", then the condition
should be "not_internalized_bit == 0", and the Then() part should push
the key while the Else() part calls Runtime_InternalizeString.
Or it should be called not_internalized, with the condition being
"not_internalized != 0", the Then() branch calling Internalize and the
Else() branch pushing the original key (as the not_internalized bit is
not unequal to 0... quadruple negation ftw!).
It would probably make sense to add a
RUNTIME_ASSERT(!StringShape(*string)->IsInternalized()) to
Runtime_InternalizeString...
https://codereview.chromium.org/356213003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
