https://codereview.chromium.org/368263003/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/368263003/diff/80001/src/code-stubs.h#newcode756
src/code-stubs.h:756: class IsJsArrayBits: public BitField<bool, 16, 1>
{};
Any particular reason you start this field at bit 16 and not 8? You may
want to make the bit selection semi-automatic like FieldIndex does.
https://codereview.chromium.org/368263003/diff/80001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/368263003/diff/80001/src/hydrogen-instructions.h#newcode2331
src/hydrogen-instructions.h:2331: if (index < 2) {
I think a little more comments/constants are needed here... what are the
first two parameters, and why are they always tagged... context and
JSFunction?
https://codereview.chromium.org/368263003/diff/80001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/368263003/diff/80001/src/ia32/lithium-ia32.cc#newcode1145
src/ia32/lithium-ia32.cc:1145: ops, zone());
clang format the patch?
https://codereview.chromium.org/368263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
