https://codereview.chromium.org/368263003/diff/180001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/368263003/diff/180001/src/runtime.cc#newcode14906
src/runtime.cc:14906: Handle<FixedArrayBase>
elements(object->elements());
I guess this is function is OK, but it bothers me a little that this
logic seems to be duplication of a bunch of logic that is in
ElementsAccessors::SetLengthWithoutNormalize,
ElementsAccessors::SetCapacityAndLength and JSArray::SetLength, or some
combination of them. It seems to me that we should try really hard to
reduce that duplication. Maybe that's for another CL, but perhaps you
can take a look whether there is an easy way to reduce the explicit
duplication in this CL.
https://codereview.chromium.org/368263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
