https://codereview.chromium.org/420753002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/420753002/diff/1/src/heap.cc#newcode58
src/heap.cc:58: // a multiple of Page::kPageSize.
move up to line above
https://codereview.chromium.org/420753002/diff/1/src/heap.cc#newcode5140
src/heap.cc:5140: "V8.IdleNotification", 0,
kMaxIdleNotificationHistogramSample,
ditto (V8.IdleNotificationHint or V8.IdleGCAllottedTime).
https://codereview.chromium.org/420753002/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/420753002/diff/1/src/heap.h#newcode2283
src/heap.h:2283: void* idle_notification_histogram_;
I'd probably call this idle_notification_hint_histogram_ (or maybe
something like idle_gc_allotted_time_histogram_ for the new scheduler
based time).
Also, any reason this isn't in counters.h - there is already a
gc_idle_notification in HISTOGRAM_TIMER_LIST.
https://codereview.chromium.org/420753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
