lgtm with a nit and an optional suggestion.
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc
File src/counters.cc (right):
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc#newcode58
src/counters.cc:58: #define HR(name, caption) name##_ =
Histogram(#caption, 0, 1000, 1001, isolate);
nit - newline after ")" like those below.
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc#newcode58
src/counters.cc:58: #define HR(name, caption) name##_ =
Histogram(#caption, 0, 1000, 1001, isolate);
optional suggestion - if you want this to be generic, maybe you could
add arguments to HR for the range and number of buckets, then they could
be parameterized seperately for each entry in the HISTOGRAM_RANGE_LIST
list, wdyt?
https://codereview.chromium.org/420753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
