On 2014/07/29 at 15:12:39, verwaest wrote:
lgtm. just a last comment.
https://codereview.chromium.org/384963002/diff/260001/src/unscopables.h
File src/unscopables.h (right):
https://codereview.chromium.org/384963002/diff/260001/src/unscopables.h#newcode25
src/unscopables.h:25: } while (false)
Can you please move these macros next to the other macros so we can use
them
as well? Maybe even put them there in a separate CL?
I have some issues with this CL as is so: Not LGTM
The test is flawed... I fixed the CL yesterday on my flight and I also
extended
the LookupIterator to keep track of the last non hidden prototype.
I'm having some technical difficulties with git cl upload on this new
laptop.
I'll ping you when I resolve them.
https://codereview.chromium.org/384963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
