LGTM for the MIPS part. (Some very small issues found that you could fix
when
landing.)
But we do still need a v8 team review for the arch-indep changes.
https://codereview.chromium.org/453043002/diff/1/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):
https://codereview.chromium.org/453043002/diff/1/src/mips/lithium-mips.cc#newcode1515
src/mips/lithium-mips.cc:1515: if (IsMipsArchVariant(kMips32r2)) {
This should be IsMipsArchVariant(kMips32r2) ||
IsMipsArchVariant(kMips32r6), as we have madd.d on both variants.
https://codereview.chromium.org/453043002/diff/1/src/mips/lithium-mips.cc#newcode1588
src/mips/lithium-mips.cc:1588: if (IsMipsArchVariant(kMips32r2)) {
as above, also allowed on mips32r6.
https://codereview.chromium.org/453043002/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):
https://codereview.chromium.org/453043002/diff/1/src/mips/macro-assembler-mips.cc#newcode928
src/mips/macro-assembler-mips.cc:928: if (IsMipsArchVariant(kMips32r2))
{
Also allow on mips32r6, we have rotr, rotrv instructions there too.
https://codereview.chromium.org/453043002/diff/1/src/mips/macro-assembler-mips.cc#newcode1150
src/mips/macro-assembler-mips.cc:1150: if (IsMipsArchVariant(kMips32r2))
{
also mips32r6
https://codereview.chromium.org/453043002/diff/1/src/mips/macro-assembler-mips.cc#newcode1174
src/mips/macro-assembler-mips.cc:1174: if (IsMipsArchVariant(kMips32r2))
{
also mips32r6
https://codereview.chromium.org/453043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
