non-MIPS changes LGTM with a few very minor formatting nits.
https://codereview.chromium.org/453043002/diff/1/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/453043002/diff/1/build/toolchain.gypi#newcode284
build/toolchain.gypi:284: 'cflags': ['-mfp64',],
nit: the comma before ']' isn't necessary (but I don't mind if it's
there).
https://codereview.chromium.org/453043002/diff/1/build/toolchain.gypi#newcode336
build/toolchain.gypi:336: 'defines':
['_MIPS_ARCH_MIPS32R6','FPU_MODE_FP64',],
nit: space after comma please
https://codereview.chromium.org/453043002/diff/1/test/cctest/test-assembler-mips.cc
File test/cctest/test-assembler-mips.cc (right):
https://codereview.chromium.org/453043002/diff/1/test/cctest/test-assembler-mips.cc#newcode822
test/cctest/test-assembler-mips.cc:822: if
(!IsMipsArchVariant(kMips32r6)) {
nit: you could avoid the increased indentation below by inverting the
condition:
if (IsMipsArchVariant(kMips32r6)) return;
https://codereview.chromium.org/453043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
