https://codereview.chromium.org/460593003/diff/20001/src/compiler/change-lowering.cc
File src/compiler/change-lowering.cc (right):
https://codereview.chromium.org/460593003/diff/20001/src/compiler/change-lowering.cc#newcode27
src/compiler/change-lowering.cc:27: Node*
ChangeLoweringBase::ExternalConstant(ExternalReference reference) {
This is a big duplication of code. Why didn't you keep the original code
with used JSGraph instead?
https://codereview.chromium.org/460593003/diff/20001/src/compiler/change-lowering.cc#newcode138
src/compiler/change-lowering.cc:138: Reduction
ChangeLowering<4>::ChangeBoolToBit(Node* val) {
This templatization of the changes is unnecessary complexity. The
original code had a simple branch on the pointer size.
https://codereview.chromium.org/460593003/diff/20001/src/compiler/change-lowering.cc#newcode200
src/compiler/change-lowering.cc:200: Reduction
ChangeLowering<4>::ChangeTaggedToFloat64(Node* val, Node* effect,
ChangeLowering<4> and ChangeLowering<8> of this method are almost
exactly alike.
https://codereview.chromium.org/460593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
