On 2014/08/13 09:14:13, Benedikt Meurer wrote:
https://codereview.chromium.org/460593003/diff/20001/src/compiler/change-lowering.cc
File src/compiler/change-lowering.cc (right):
https://codereview.chromium.org/460593003/diff/20001/src/compiler/change-lowering.cc#newcode138
src/compiler/change-lowering.cc:138: Reduction
ChangeLowering<4>::ChangeBoolToBit(Node* val) {
That's another option, sure. But I decided to do it this way.
This is not necessary complexity. You undid a simple branch and replaced it
with
template specialization on the pointer size. This an abuse of templates with
clear disadvantages and little or no benefit.
Can we please go back to the simpler code?
https://codereview.chromium.org/460593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
