https://codereview.chromium.org/509343002/diff/1/src/compiler/generic-node-inl.h
File src/compiler/generic-node-inl.h (right):
https://codereview.chromium.org/509343002/diff/1/src/compiler/generic-node-inl.h#newcode26
src/compiler/generic-node-inl.h:26: inputs_.static_ =
reinterpret_cast<Input*>(this + 1);
That's a nice little gift
https://codereview.chromium.org/509343002/diff/1/src/compiler/graph.h
File src/compiler/graph.h (right):
https://codereview.chromium.org/509343002/diff/1/src/compiler/graph.h#newcode83
src/compiler/graph.h:83: bool is_typed() const { return is_typed_; }
Gah, we went through this with the source positions. Please don't make
the graph stateful. That's the whole point of the decorators. Maybe you
can have IsDecoratedWith?
https://codereview.chromium.org/509343002/diff/1/src/compiler/js-graph.cc
File src/compiler/js-graph.cc (right):
https://codereview.chromium.org/509343002/diff/1/src/compiler/js-graph.cc#newcode157
src/compiler/js-graph.cc:157: graph()->Decorate(*loc);
Why are you explicitly calling Decorate all over the place now?
https://codereview.chromium.org/509343002/diff/1/src/compiler/opcodes.h
File src/compiler/opcodes.h (right):
https://codereview.chromium.org/509343002/diff/1/src/compiler/opcodes.h#newcode9
src/compiler/opcodes.h:9: #define INNER_CONTROL_OP_LIST(V) \
I am not a fan of splitting up all the operators into tons of different
lists.
https://codereview.chromium.org/509343002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
