Reviewers: Mads Ager, Description: Fixed SCons build of Windows DLL.
The configuration for building the Windows shared library was lost when adding x64 Windows build to the SCons build. This should now be back. Please review this at http://codereview.chromium.org/197036 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M SConstruct Index: SConstruct =================================================================== --- SConstruct (revision 2827) +++ SConstruct (working copy) @@ -258,6 +258,10 @@ 'all': { 'WARNINGFLAGS': ['/WX', '/wd4355', '/wd4800'] }, + 'library:shared': { + 'CPPDEFINES': ['BUILDING_V8_SHARED'], + 'LIBS': ['winmm', 'ws2_32'] + }, 'arch:ia32': { 'WARNINGFLAGS': ['/W3'] }, --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
