lgtm
https://codereview.chromium.org/564823003/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/564823003/diff/1/src/compiler/js-typed-lowering.cc#newcode231
src/compiler/js-typed-lowering.cc:231: // JSAdd(x:-string, y:-string) =>
NumberAdd(ToNumber(x), ToNumber(y))
On 2014/09/11 14:25:44, Michael Starzinger wrote:
I convinced myself that this is correct for ES5, could you please make
extra-sure on whether this also holds in ES6?
It seems correct, as long as ToNumber(symbol) throws a TypeError (which
is currently the case in the draft, but I remember some discussion about
changing it).
https://codereview.chromium.org/564823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
