PTAL.
https://codereview.chromium.org/607503004/diff/60001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/607503004/diff/60001/src/array.js#newcode383
src/array.js:383: var e = array[0];
On 2014/09/29 22:09:42, arv wrote:
Maybe:
if (length === 1) return TO_STRING_INLINE(array[0]);
That will not work, we need to check for null and undefined, as they
have a different behavior under join (they return '' instead of 'null'
and 'undefined' respectively,
it is also 2X slower for strings, 20% slower for numbers and boolean.
But I took your advice, now all length === 1 are handled here.
https://codereview.chromium.org/607503004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
