Reviewers: *Michael Starzinger, Sven Panne,
Message:
PTAL; this is the patch from yesterday with a couple of modifications
mentioned
in the comments below.
https://codereview.chromium.org/683023002/diff/20001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/683023002/diff/20001/src/compiler.cc#newcode650
src/compiler.cc:650: if (!Compiler::Analyze(info) ||
!FullCodeGenerator::MakeCode(info)) {
This part changed since the last patch to signal StackOverflow() if
analysis fails and there is no pending exception
https://codereview.chromium.org/683023002/diff/20001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/683023002/diff/20001/src/compiler/js-inlining.cc#newcode377
src/compiler/js-inlining.cc:377: // TODO(wingo): ParseAndAnalyze can
fail due to stack overflow.
Here I added this TODO. Should we just return if parse/analyze fails?
I would think so.
Description:
Move AST node counting to post-pass
R=mstarzin...@chromium.org, svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/683023002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+107, -66 lines):
M src/ast.h
M src/ast.cc
M src/ast-numbering.cc
M src/compiler.h
M src/compiler.cc
M src/compiler/js-inlining.cc
M src/full-codegen.cc
M src/hydrogen.cc
M test/cctest/compiler/function-tester.h
M test/cctest/compiler/test-codegen-deopt.cc
M test/cctest/compiler/test-pipeline.cc
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
