On 2014/11/13 15:18:05, marja wrote:
(Thanks for having a look)


https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):


https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc#newcode4322
test/cctest/test-parsing.cc:4322: "var foob\\u{c481r = 0;",
On 2014/11/13 15:09:18, caitp wrote:
> Might be worth adding a test for `var \\not-u` being treated as a syntax
error.

By var \not-u do you mean var \X where X is some letter other than u? Or
something else?

Yeah exactly, it would have caught the little typo bugs in the other CL, so it
might be worth having it in case it accidentally breaks in the future

https://codereview.chromium.org/716423002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to