Regarding extra tests. How about an object that has getters for all the flags and then assert that these are called in the right order? Also, do the same thing with the getters returning objects with valueOf to ensure that the valueOf is called before the next getter is invoked.
On Sat, Dec 13, 2014 at 2:04 AM, <math...@qiwi.be> wrote: > > On 2014/12/10 21:03:28, arv wrote: > >> I think the tests could have been a bit more extensive but this is good >> > enough. > > What kind of additional tests did you have in mind? I’ll do a follow-up > patch > that fixes the configurability soon and I’d love to add some more tests. > > Re: configurability, I assumed > https://people.mozilla.org/~jorendorff/es6-draft.html#table-4 applied but > actually the last paragraph of section 17 overrules this: > https://people.mozilla.org/~jorendorff/es6-draft.html#sec- > ecmascript-standard-built-in-objects > > > https://codereview.chromium.org/770333005/ > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > ---You received this message because you are subscribed to the Google > Groups "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- erik -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
