Reviewers: caitp, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Ship ES6 template literals
BUG=v8:3230
LOG=Y
[email protected], [email protected]
Please review this at https://codereview.chromium.org/808413004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -6 lines):
M src/flag-definitions.h
M test/webkit/fast/js/Object-getOwnPropertyNames.js
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
ff68475992a2717f5b7d6b7896595c47ec49aa30..77af030a9533b2e5ce48bcc0a6288aaaf5844bf1
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -183,9 +183,7 @@ DEFINE_IMPLICATION(es_staging, harmony)
V(harmony_unicode, "harmony unicode escapes")
// Features that are complete (but still behind --harmony/es-staging flag).
-#define HARMONY_STAGED(V) \
- V(harmony_tostring, "harmony toString") \
- V(harmony_templates, "harmony template literals")
+#define HARMONY_STAGED(V) V(harmony_tostring, "harmony toString")
// Features that are shipping (turned on by default, but internal flag
remains).
#define HARMONY_SHIPPING(V) \
@@ -194,7 +192,8 @@ DEFINE_IMPLICATION(es_staging, harmony)
V(harmony_scoping, "harmony block scoping") \
V(harmony_classes, \
"harmony classes (implies block scoping & object literal extension)") \
- V(harmony_object_literals, "harmony object literal extensions")
+ V(harmony_object_literals, "harmony object literal extensions") \
+ V(harmony_templates, "harmony template literals")
// Once a shipping feature has proved stable in the wild, it will be
dropped
// from HARMONY_SHIPPING, all occurrences of the FLAG_ variable are
removed,
Index: test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
diff --git a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
index
ca47dec6c7e74c118aa14db5241fff4a12351497..c96c8361fd559ab0fd32b27d1e069a31acb06d8c
100644
--- a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
+++ b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
@@ -50,7 +50,7 @@ PASS getSortedOwnPropertyNames(Function) is
['arguments', 'caller', 'length', 'n
PASS getSortedOwnPropertyNames(Function.prototype) is
['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toMethod', 'toString']
PASS getSortedOwnPropertyNames(Array) is
['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 'prototype', 'unobserve']
PASS getSortedOwnPropertyNames(Array.prototype) is
['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift']
-PASS getSortedOwnPropertyNames(String) is
['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype']
+PASS getSortedOwnPropertyNames(String) is
['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']
PASS getSortedOwnPropertyNames(String.prototype) is
['anchor', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'normalize', 'repeat', 'replace', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimLeft', 'trimRight', 'valueOf']
PASS getSortedOwnPropertyNames(Boolean) is
['arguments', 'caller', 'length', 'name', 'prototype']
PASS getSortedOwnPropertyNames(Boolean.prototype) is
['constructor', 'toString', 'valueOf']
Index: test/webkit/fast/js/Object-getOwnPropertyNames.js
diff --git a/test/webkit/fast/js/Object-getOwnPropertyNames.js
b/test/webkit/fast/js/Object-getOwnPropertyNames.js
index
4ea5d598cfad7c70e101b70615b2c790347a1151..46d796666472f07240acede40a11be4d14aeda56
100644
--- a/test/webkit/fast/js/Object-getOwnPropertyNames.js
+++ b/test/webkit/fast/js/Object-getOwnPropertyNames.js
@@ -77,7 +77,7 @@ var expectedPropertyNamesSet = {
"Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller',
'constructor', 'length', 'name', 'toMethod', 'toString']",
"Array": "['arguments', 'caller', 'isArray', 'length', 'name', 'observe',
'prototype', 'unobserve']",
"Array.prototype": "['concat', 'constructor', 'entries', 'every', 'filter',
'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce',
'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString',
'unshift']",
- "String": "['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length',
'name', 'prototype']",
+ "String": "['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length',
'name', 'prototype', 'raw']",
"String.prototype": "['anchor', 'big', 'blink', 'bold', 'charAt', 'charCodeAt',
'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes',
'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'normalize',
'repeat', 'replace', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr',
'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString',
'toUpperCase', 'trim', 'trimLeft', 'trimRight', 'valueOf']",
"Boolean": "['arguments', 'caller', 'length', 'name', 'prototype']",
"Boolean.prototype": "['constructor', 'toString', 'valueOf']",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
