https://codereview.chromium.org/791473003/diff/40001/src/compiler/mips/code-generator-mips.cc
File src/compiler/mips/code-generator-mips.cc (right):
https://codereview.chromium.org/791473003/diff/40001/src/compiler/mips/code-generator-mips.cc#newcode289
src/compiler/mips/code-generator-mips.cc:289: __ Branch(USE_DELAY_SLOT,
&done, hs, at, Operand(1075)); \
Hmmm, would prefer we don't use so many magic numbers here. There are
constants:
HeapNumber::kExponentShift, HeapNumber::kExponentBits, and your
1075 = HeapNumber::kExponentBias + HeapNumber::kMantissaBits
Even with those defs, it is probably worth a comment to mention that
there is no fractional part when the exponent is > number of mantissa
bits, so your intent is clear.
Same for mips64 version of this.
https://codereview.chromium.org/791473003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
