On 2014/12/18 11:21:22, Benedikt Meurer wrote:
Nice, looks almost too easy. What is the test coverage for this?
I've added some test/mjsunit/compiler/*osr* tests that explicitly enable
--turbo-osr for outermost OSR loops. Additionally, I've added a few unit
tests
that check the graph rewriting in test/cctest/compiler/test-osr.cc.
Also added documentation in src/compiler/osr.h
https://codereview.chromium.org/809333002/diff/20001/src/compiler/arm/code-generator-arm.cc
File src/compiler/arm/code-generator-arm.cc (right):
https://codereview.chromium.org/809333002/diff/20001/src/compiler/arm/code-generator-arm.cc#newcode890
src/compiler/arm/code-generator-arm.cc:890: // TODO(titzer): put an abort
into
the header of OSR functions on arm.
MacroAssembler::Abort()
https://codereview.chromium.org/809333002/diff/20001/src/compiler/arm64/code-generator-arm64.cc
File src/compiler/arm64/code-generator-arm64.cc (right):
https://codereview.chromium.org/809333002/diff/20001/src/compiler/arm64/code-generator-arm64.cc#newcode977
src/compiler/arm64/code-generator-arm64.cc:977: // TODO(titzer): put an
abort
into the header of OSR functions on arm64.
MacroAssembler::Abort()
https://codereview.chromium.org/809333002/diff/20001/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):
https://codereview.chromium.org/809333002/diff/20001/src/compiler/code-generator.cc#newcode270
src/compiler/code-generator.cc:270: // No OSR in Turbofan yet...
Remove this comment.
https://codereview.chromium.org/809333002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
